-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bugs only pointable with Bug Net #3099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the "legacy compatibility" works if an old client connects to a new server: The server will set pointable = false
for the fireflies and butterflies. The old client will not be able to point at them, since it doesn't understand the pointabilities
.
I'm not sure what to do about this however. I currently see three options:
- Using the current API, we could let fireflies remain pointable, but add
pointabilities = false
to all tools by default (for example by monkey-patchingminetest.register_tool
). This is quite hacky, however. - Perhaps we could adapt the pointabilities API to allow specifying a fallback for backwards-compatibility or similar?
- Just ignore it. Not all that bad, actually. New clients on new servers will be fine. Old servers will be fine to (and just not take advantage of this). And this is a pretty minor feature anyways.
Yeah, the compatibility is only for old Minetest versions which use a new MTG version. The only good way I see to solve this is to add a feature to Minetest which allows sending different item definitions to clients depending on the client version. However, this would be a huge effort and it will rarely be used. So I think it is reasonable to just ignore it, in case this PR gets merged. |
To be clear (in the past) MTG did require the server to be up-to-date but we still couldn't use something (e.g. formspecs) that flat-out did not work on older clients. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can live with older clients being unable to catch bugs. (And since bugs have buildable_to = true
, it's not like they are indestructible for older clients.)
* Add legacy compatibility making to work with older clients * backported minetest/minetest_game#3099 * backported commit minetest/minetest_game@ef788d0
Problem
Sometimes a firefly or a butterfly is in your way when you want to dig something, and it can't be destroyed by punching it.
It basically behaves like punching stone with a bare hand. This is unreasonable and annoying.
What does this PR do?
This PR makes fireflies and butterflies only pointable using a bug net.
It utilizes the new pointabilities feature.
Alternatives