Better sapling grow system #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
reviewed
Aug 26, 2023
|
@SmallJoker Thanks for your review. I have added a brief description of every public element added in my code, could you please take a look into it? |
|
Are there any other patches required to my contribution? I may have some spare time during next week to fix any possible issue. |
|
I will try to get to reviewing this tomorrow. |
appgurueu
approved these changes
Sep 11, 2023
Co-authored-by: sfan5 <[email protected]>
Co-authored-by: sfan5 <[email protected]>
MoNTE48
pushed a commit
to MoNTE48/minetest_game
that referenced
this pull request
Oct 8, 2023
--------- Co-authored-by: Lars Müller <[email protected]> Co-authored-by: sfan5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests implements the changes proposed in issue #3050 to clean the sapling growth system implemented in the default game. My modifications add a generic register_sapling_growth function that may be linked as a public API, although I am not sure this is idiomatic in the way the game is developed. A further step may be to separate the tree growing system to a separate module such that other modules may register their own trees with ease and without interacting with "default".