close chest: don't replace a node if it's not the expected open chest #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
approved these changes
Aug 11, 2023
|
If you know even more such issues, please report them 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is similar to #3045. currently, closing a chest dialogue will replace anything currently at the location of the chest when the dialogue was opened, even if it's another node or air. currently this can be exploited very reliably w/ mesecons sticky pistons, but other players have reported that it can be exploited unreliably w/ tnt (even though open chests should be tnt-proof?). but in general, there's no way to guarantee that the node hasn't changed since we opened it.