-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move chests to a new file. Update credits for chests and torches #2171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the torch textures license info - any reason not to have all Vanessa's textures grouped in one place? They are all the same license, so I don't see why the torch ones are singled out as separate.
Agreed, will update. |
Move chests code out of nodes.lua and into a new file. Credit torch code, and chest and torch models in README.txt. Remove 'torches' mod text from torch.lua. Minor cleanups in README.txt.
just to ask, why not just it's own mod entirely? code and media if the .lua is to be isolated, it only makes sense to isolate the media files as well with it, and it is justified. |
Updated as requested and tested. Tumeni i agree, however that is difficult and messy to do for various reasons. We are very keen on making MTG as modular as possible, have split off what we can and make new stuff separate mods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good.
As much as I dislike overrides, and aliases, they could be justified in this case. |
Move chests to a new file. Update credits for chests and torches
Move chests code out of nodes.lua and into a new file.
Credit torch code, and chest and torch models in README.txt.
Remove 'torches' mod text from torch.lua.
Minor cleanups in README.txt.
//////////////
Closes #2149