Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move chests to a new file. Update credits for chests and torches #2171

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Move chests to a new file. Update credits for chests and torches #2171

merged 1 commit into from
Jul 10, 2018

Conversation

paramat
Copy link
Contributor

@paramat paramat commented Jul 9, 2018

Move chests to a new file. Update credits for chests and torches

Move chests code out of nodes.lua and into a new file.
Credit torch code, and chest and torch models in README.txt.
Remove 'torches' mod text from torch.lua.
Minor cleanups in README.txt.
//////////////
Closes #2149

Copy link
Contributor

@Ezhh Ezhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the torch textures license info - any reason not to have all Vanessa's textures grouped in one place? They are all the same license, so I don't see why the torch ones are singled out as separate.

@paramat
Copy link
Contributor Author

paramat commented Jul 10, 2018

Agreed, will update.

Move chests code out of nodes.lua and into a new file.
Credit torch code, and chest and torch models in README.txt.
Remove 'torches' mod text from torch.lua.
Minor cleanups in README.txt.
@TumeniNodes
Copy link
Contributor

TumeniNodes commented Jul 10, 2018

just to ask, why not just it's own mod entirely? code and media

if the .lua is to be isolated, it only makes sense to isolate the media files as well with it, and it is justified.

@paramat paramat removed the WIP label Jul 10, 2018
@paramat
Copy link
Contributor Author

paramat commented Jul 10, 2018

Updated as requested and tested.

Tumeni i agree, however that is difficult and messy to do for various reasons. We are very keen on making MTG as modular as possible, have split off what we can and make new stuff separate mods.
See #726

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good.

@TumeniNodes
Copy link
Contributor

TumeniNodes commented Jul 10, 2018

As much as I dislike overrides, and aliases, they could be justified in this case.
But I agree with your statement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants