Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ores: Remove region overlaps. Make some regions deeper #2056

Closed
wants to merge 1 commit into from
Closed

Ores: Remove region overlaps. Make some regions deeper #2056

wants to merge 1 commit into from

Conversation

paramat
Copy link
Contributor

@paramat paramat commented Feb 25, 2018

#2047 rebased, no other changes.
/////////////////

Remove overlapping coal/iron ore regions for consistency with all
other ores.
In lower coal/iron regions increase number of clusters to compensate for
removed overlaps.
Decrease dimension of these clusters to better match the 'ores to cluster
volume' ratio of the small clusters.

Move density increase for coal and iron to y = -127.
Make tin deeper with region depths identical to copper.
////////////////

Mgv6 is not affected by this change.

Previously for both coal and iron:
The top region of small clusters continued down to world base, overlapping the deeper region of large clusters. This is from early MTG which had few ores, now we have many more making ore generation more intensive. This PR removes this overlap but preserves the ore density in the lower region by making the large clusters more common.
Removing the overlap will make ore generation a little less intensive.
The small clusters of the upper region is unchanged so this doesn't affect gameplay for beginners.

Previously the lower regions for coal and iron started at a much too easy y = 0 and y = -64, move the lower region down to start at y = -128.

Make tin deeper, since it is equivalent to copper in the progression of ores make the depths of its regions identical to copper: upper starts at y = -128, lower starts at y = -256.

This PR is therefore the second part of the 'make ores deeper' task started in #1813 In that PR i didn't alter coal and iron regions, so this PR does that.

The ore progression of value and depth is now (same line = same value/depth):

Coal, Iron
Tin, Copper
Gold
Diamond, Mese crystal
Mese block

@paramat
Copy link
Contributor Author

paramat commented Mar 2, 2018

I'm feeling quite stubborn about this, the inconsistency bothers me and the overlap complicates stuff.

@paramat
Copy link
Contributor Author

paramat commented Mar 4, 2018

By the way, mgv6 ores are not changed, to preserve the character of mgv6.

For the other mapgens, with the number of ores we have now, and underground becoming more complex, i don't think duplicating ores is a luxury that can be justified anymore, we certainly can't do it for all ores and the inconsistency is messy. The loss of one cluster type is minor and compensated by everything else we have added, and will add.

@Ezhh
Copy link
Contributor

Ezhh commented Mar 5, 2018

👍

@paramat
Copy link
Contributor Author

paramat commented Mar 5, 2018

3afcd68

@paramat paramat closed this Mar 5, 2018
@paramat paramat deleted the tuneore branch March 19, 2018 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants