-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTG content removal and overhauling part 1 #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overhaul of the Mapgen page looks good when reading it through, and 👍 on the removal and move of the respective pages
|
||
#### Gallery | ||
[![](/images/mapgen/Mapgen_v5.jpg)](/images/mapgen/Mapgen_v5.jpg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right way to format links? Can't we just do:
[![](/images/mapgen/Mapgen_v5.jpg)](/images/mapgen/Mapgen_v5.jpg) | |
![](/images/mapgen/Mapgen_v5.jpg) |
I guess the original way of doing things allows users to click on the image to be taken to the image on its own, but I'm not sure.
Not a blocker from me though, feel free to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is just a bit of a blemish from the way wikitext gets converted to markdown. I'm unsure what we should decide upon, if we want clickable links then this should be done in a way that can be reusable across all images on the site (and that can include captions, floating them to the right and such like the MediaWiki image functionality).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the image is nested in a link so you can click it to open. This is also done on other pages. I think it would make sense to adjust the template so that all images get links to open them, and then remove those from the markdown source.
In this PR, I think they should stay since they're useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good cleanup. I just have some punctuation and wordsmithing requests.
Co-authored-by: JosiahWI <[email protected]>
Co-authored-by: JosiahWI <[email protected]>
Co-authored-by: JosiahWI <[email protected]>
Co-authored-by: JosiahWI <[email protected]>
resolves part of #80