Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTG content removal and overhauling part 1 #81

Merged
merged 7 commits into from
Dec 21, 2024

Conversation

grorp
Copy link
Member

@grorp grorp commented Dec 21, 2024

resolves part of #80

  • overhauled the "Mapgen" page to be more useful/informative, and to remove the "Luanti == Minetest Game" assumption
    • also updated some other outdated stuff, like "advanced settings menu"
    • removed references to MTG nodes (there are still node name references, but they're meant to refer to node aliases / biome nodes, not to specific MTG nodes)
  • moved the "Custom Lua Mapgen" page into the "Mapgen" category
  • removed pages where consensus apparently exists

@JosiahWI JosiahWI added the Content Alterations or additions to written content label Dec 21, 2024
@JosiahWI JosiahWI self-requested a review December 21, 2024 13:23
Copy link
Member

@rollerozxa rollerozxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overhaul of the Mapgen page looks good when reading it through, and 👍 on the removal and move of the respective pages


#### Gallery
[![](/images/mapgen/Mapgen_v5.jpg)](/images/mapgen/Mapgen_v5.jpg)
Copy link
Contributor

@mark-wiemer mark-wiemer Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right way to format links? Can't we just do:

Suggested change
[![](/images/mapgen/Mapgen_v5.jpg)](/images/mapgen/Mapgen_v5.jpg)
![](/images/mapgen/Mapgen_v5.jpg)

I guess the original way of doing things allows users to click on the image to be taken to the image on its own, but I'm not sure.

Not a blocker from me though, feel free to merge

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is just a bit of a blemish from the way wikitext gets converted to markdown. I'm unsure what we should decide upon, if we want clickable links then this should be done in a way that can be reusable across all images on the site (and that can include captions, floating them to the right and such like the MediaWiki image functionality).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the image is nested in a link so you can click it to open. This is also done on other pages. I think it would make sense to adjust the template so that all images get links to open them, and then remove those from the markdown source.

In this PR, I think they should stay since they're useful.

Copy link
Contributor

@JosiahWI JosiahWI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup. I just have some punctuation and wordsmithing requests.

content/mapgen/_index.md Outdated Show resolved Hide resolved
content/mapgen/_index.md Outdated Show resolved Hide resolved
content/mapgen/_index.md Outdated Show resolved Hide resolved
content/mapgen/_index.md Outdated Show resolved Hide resolved
@rollerozxa rollerozxa merged commit ba55e95 into minetest:master Dec 21, 2024
2 checks passed
@grorp grorp deleted the mtg-pt1 branch December 21, 2024 13:44
grorp added a commit that referenced this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Alterations or additions to written content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants