Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the bags being dumped into the bones block on death (configurable) #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imre84
Copy link

@imre84 imre84 commented May 4, 2023

works well with the bones mod I'm about to upload in a couple of minutes

@SmallJoker
Copy link
Member

SmallJoker commented May 4, 2023

Honestly speaking, it could be implemented in a much fancier way by introducing a public function in the bones mod (minetest_game) which is called to collect the item stacks that shall be handled. It would be easy for mods to register a callback of overwrite said function to handle it correctly.
This node searching approach might still hit the wrong bone if there are multiple ones nearby from the same player.

@imre84
Copy link
Author

imre84 commented May 5, 2023

Honestly speaking, it could be implemented in a much fancier way by introducing a public function in the bones mod (minetest_game) which is called to collect the item stacks that shall be handled. It would be easy for mods to register a callback of overwrite said function to handle it correctly. This node searching approach might still hit the wrong bone if there are multiple ones nearby from the same player.

Hello, working on it: minetest/minetest_game#3030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants