Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grinding recipe for nether lump + refactor grinder recipes #638

Conversation

gabriel1379
Copy link
Contributor

@gabriel1379 gabriel1379 commented Apr 7, 2024

Hi,

I'm also using the nether mod and wanted to be able to grind nether lumps, so I added a recipe for it.

Also, since I was already at the file and saw that it was getting bigger and harder to overview, refactored it a bit to make it more compact and easier to handle.

(Also, the .png image has been crushed.)

@Desour
Copy link
Contributor

Desour commented Apr 10, 2024

Please note that there is more than one nether mod. Using minetest.get_modpath alone is not enough to check for the right one.

@gabriel1379
Copy link
Contributor Author

Please note that there is more than one nether mod. Using minetest.get_modpath alone is not enough to check for the right one.

Thanks for the hint. Additional check added (also to the other PR). Please check and let me know if that's OK or if anything else is needed.

@Desour
Copy link
Contributor

Desour commented Apr 13, 2024

Please check and let me know if that's OK or if anything else is needed.

To be clear, I'm not a maintainer of this mod, I just wanted to make sure it doesn't get incompatible with some mods. :)

@gabriel1379
Copy link
Contributor Author

Please check and let me know if that's OK or if anything else is needed.

To be clear, I'm not a maintainer of this mod, I just wanted to make sure it doesn't get incompatible with some mods. :)

Ah, ok. Still, thanks for the hint. :)

@SmallJoker
Copy link
Member

Please note that there is more than one nether mod. Using minetest.get_modpath alone is not enough to check for the right one.

(similar argumentation as in #639) For recipes it does not matter which version of the nether` mod is enabled. The worst case is not being able to craft the item (e.g. missing ingredient).

Hence I think it is fine to keep it simple for now.


LGTM. Will merge this PR in a few days unless there are objections.

@SmallJoker SmallJoker merged commit 80dee96 into minetest-mods:master May 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants