Fix deprecated function calls #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niklp09
approved these changes
Jun 17, 2024
This comment was marked as outdated.
This comment was marked as outdated.
|
I re-requested approval because of the significant change on |
BuckarooBanzay
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
didn't test but the code looks good 👍 (up to you now @Niklp09 😏)
Niklp09
reviewed
Jun 19, 2024
|
LGTM. Will merge in a few days unless there are objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaces deprecated calls. The following are fixed:
ObjectRef:moveto()(Replaced byObjectRef:add_pos()orObjectRef:move_to()depending on engine version)ObjectRef:setyaw()(Replaced byObjectRef:set_yaw())MetaDataRef:set_string()withnilas the second parameter (Replaced by"")The following one is purposely not fixed:
digtron/nodes/node_crate.lua
Line 296 in 64416fd
This PR is ready for review.