Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecdsa use base64 url encoding without padding #88

Merged
merged 2 commits into from
Feb 5, 2024
Merged

ecdsa use base64 url encoding without padding #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
757fe07
ecdsa use base64 url encoding without padding
ChristopherHX Feb 4, 2024
40aec42
Merge branch 'master' into ecdsa-use-base64-url
ChristopherHX Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/jni/ecdsa.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,14 @@ Ecdsa::~Ecdsa() {
}

void Ecdsa::generateKey(std::shared_ptr<FakeJni::JString> unique_id) {
if(eckey) {
EC_KEY_free(eckey);
eckey = nullptr;
}
if(ecgroup) {
EC_GROUP_free(ecgroup);
ecgroup = nullptr;
}
this->unique_id = unique_id;
ecgroup = EC_GROUP_new_by_curve_name(NID_X9_62_prime256v1); // openssl alias of secp256r1
if(!ecgroup) {
Expand Down Expand Up @@ -102,13 +110,26 @@ EcdsaPublicKey::EcdsaPublicKey(EC_KEY *eckey, EC_GROUP *ecgroup) {
if(BN_bn2bin(x, (unsigned char *)buf.data()) != len) {
throw std::runtime_error("OpenSSL failed to export bignum");
}
xbase64 = Base64::encode(buf);
// the game uses three base64 flags for https://developer.android.com/reference/android/util/Base64
// NO_PADDING | NO_WRAP | URL_SAFE, although the sisu auth service seem to accept normal base64 with padding
auto base64tobase64url = [](char x) {
if(x == '+') {
return '-';
}
if(x == '/') {
return '_';
}
return x;
};
xbase64 = Base64::encode(buf, false);
std::transform(xbase64.begin(), xbase64.end(), xbase64.begin(), base64tobase64url);
len = BN_num_bytes(y);
buf = std::string(len, '_');
if(BN_bn2bin(y, (unsigned char *)buf.data()) != len) {
throw std::runtime_error("OpenSSL failed to export bignum");
}
ybase64 = Base64::encode(buf);
ybase64 = Base64::encode(buf, false);
std::transform(ybase64.begin(), ybase64.end(), ybase64.begin(), base64tobase64url);
}

std::shared_ptr<FakeJni::JString> EcdsaPublicKey::getBase64UrlX() {
Expand Down
Loading