Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXP-675: [CLI] Make canary flag enabled by default #201

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

jk-gan
Copy link
Contributor

@jk-gan jk-gan commented Mar 6, 2024

Summary

Screenshot 2024-03-06 at 3 57 11 PM

Ticket: PXP-675

What's Changed

Changed

  • The --canary flag is now true by default starting from v2.1.0

@jk-gan jk-gan requested review from Fadhil, onimsha and mfauzaan March 6, 2024 07:56
@jk-gan jk-gan self-assigned this Mar 6, 2024
Copy link
Member

@mfauzaan mfauzaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@onimsha onimsha merged commit 9edaec6 into main Mar 6, 2024
5 checks passed
@sauron-droid sauron-droid deleted the feat/default-canary branch March 6, 2024 12:31
@sauron-droid
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jk-gan, mfauzaan, onimsha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants