Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This PR removes obsolete attributes from spans #70

Merged
merged 2 commits into from
Jan 20, 2025
Merged

This PR removes obsolete attributes from spans #70

merged 2 commits into from
Jan 20, 2025

Conversation

maciej-szlosarczyk
Copy link
Contributor

These are already replaced by either http.status_code or net.peer.name so we are not losing anything. But it is still breaking change, so the version increases to 2.x

@maciej-szlosarczyk maciej-szlosarczyk force-pushed the remove-obsolete-attributes branch from 71b5944 to 7d1848c Compare January 15, 2025 07:59
@maciej-szlosarczyk
This PR removes obsolete attributes from spans
752f60c 
These are already replaced by either `http.status_code` or
`net.peer.name` so we are not losing anything.

Signed-off-by: Maciej Szlosarczyk [email protected]
@maciej-szlosarczyk maciej-szlosarczyk force-pushed the remove-obsolete-attributes branch from 7d1848c to 752f60c Compare January 15, 2025 08:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

Test coverage: Elixir 1.15.6 / OTP 26.2

File Coverage Missing
All files 74% ✅
mv_opentelemetry/oban.ex 64% ❌ 31 69-74
mv_opentelemetry/tesla.ex 84% ✅ 69-70 74 86-87
mv_opentelemetry/plug.ex 82% ✅ 62 114-115 138 146-151
mv_opentelemetry/finch.ex 79% ✅ 77-80 87 100-101

Minimum allowed coverage is 74%

Generated by cobertura-action against 184844a

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

Test coverage: Elixir 1.15.6 / OTP 25.2

File Coverage Missing
All files 74% ✅
mv_opentelemetry/oban.ex 64% ❌ 31 69-74
mv_opentelemetry/tesla.ex 84% ✅ 69-70 74 86-87
mv_opentelemetry/plug.ex 82% ✅ 62 114-115 138 146-151
mv_opentelemetry/finch.ex 79% ✅ 77-80 87 100-101

Minimum allowed coverage is 74%

Generated by cobertura-action against 184844a

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

Test coverage: Elixir 1.16.1 / OTP 25.2

File Coverage Missing
All files 74% ✅
mv_opentelemetry/oban.ex 64% ❌ 31 69-74
mv_opentelemetry/tesla.ex 84% ✅ 69-70 74 86-87
mv_opentelemetry/plug.ex 82% ✅ 62 114-115 138 146-151
mv_opentelemetry/finch.ex 79% ✅ 77-80 87 100-101

Minimum allowed coverage is 74%

Generated by cobertura-action against 184844a

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

Test coverage: Elixir 1.16.1 / OTP 26.2

File Coverage Missing
All files 74% ✅
mv_opentelemetry/oban.ex 64% ❌ 31 69-74
mv_opentelemetry/tesla.ex 84% ✅ 69-70 74 86-87
mv_opentelemetry/plug.ex 82% ✅ 62 114-115 138 146-151
mv_opentelemetry/finch.ex 79% ✅ 77-80 87 100-101

Minimum allowed coverage is 74%

Generated by cobertura-action against 184844a

@maciej-szlosarczyk
Remove unused attribute from messaging
184844a 
This attribute has been removed from specification, we also don't
really use it for anything - there are no other types than queues in
Oban.

Bundling it with this PR to use just one version increment.

Signed-off-by: Maciej Szlosarczyk [email protected]
@sauron-droid
Copy link

LGTM label has been added.

Git tree hash: 1c9129e23313a32689fbb5f85e0ce8450c2f5005

@sauron-droid
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antonsatin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maciej-szlosarczyk maciej-szlosarczyk merged commit 109c4fc into main Jan 20, 2025
12 checks passed
@maciej-szlosarczyk maciej-szlosarczyk deleted the remove-obsolete-attributes branch January 20, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonsatin antonsatin antonsatin approved these changes

@bruno-azenha bruno-azenha Awaiting requested review from bruno-azenha

@Fadhil Fadhil Awaiting requested review from Fadhil

Assignees

@antonsatin antonsatin

Labels
approved dco-signoff: yes lgtm size/M
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciej-szlosarczyk @sauron-droid @antonsatin