Skip to content

[Fix] Correct condition for image dilation in orientation estimation #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

[Fix] Correct condition for image dilation in orientation estimation #1971

merged 1 commit into from
Jun 25, 2025

Conversation

Razlaw
Copy link
Contributor

@Razlaw Razlaw commented Jun 25, 2025 •
edited
Loading

@Razlaw Razlaw changed the title [Fix] Correct condition for image dilation in orientation estimation #1970 [Fix] Correct condition for image dilation in orientation estimation Jun 25, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.87%. Comparing base (d1974d9) to head (da16ec3).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1971      +/-   ##
==========================================
- Coverage   96.91%   96.87%   -0.05%     
==========================================
  Files         172      172              
  Lines        8633     8633              
==========================================
- Hits         8367     8363       -4     
- Misses        266      270       +4
Flag Coverage Δ
unittests 96.87% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@felixdittrich92 felixdittrich92 self-assigned this Jun 25, 2025
@felixdittrich92 felixdittrich92 added this to the 1.0.0 milestone Jun 25, 2025
@felixdittrich92 felixdittrich92 added type: bug Something isn't working module: models Related to doctr.models labels Jun 25, 2025
@felixdittrich92 felixdittrich92 linked an issue Jun 25, 2025 that may be closed by this pull request
Potential bug in estimate_orientation function #1970
Closed
@felixdittrich92
Copy link
Collaborator

felixdittrich92 commented Jun 25, 2025 •
edited
Loading

@Razlaw I think at line 103 same case :)

@Razlaw Razlaw force-pushed the fix/dilate_only_if_page_orientation_is_none branch from ae08a1e to da16ec3 Compare June 25, 2025 08:59
@Razlaw
Copy link
Contributor Author

Razlaw commented Jun 25, 2025

@Razlaw I think at line 103 same case :)

Nice catch 👍 I added that.

felixdittrich92
felixdittrich92 approved these changes Jun 25, 2025
View reviewed changes
Copy link
Collaborator

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@felixdittrich92 felixdittrich92 merged commit 9c8cfdb into mindee:main Jun 25, 2025
72 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixdittrich92 felixdittrich92 felixdittrich92 approved these changes

Assignees

@felixdittrich92 felixdittrich92

Labels
module: models Related to doctr.models type: bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Potential bug in estimate_orientation function
2 participants
@Razlaw @felixdittrich92