Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add new pytorch db_resnet50 checkpoint #1840

Closed
wants to merge 1 commit into from
Closed

[feat] Add new pytorch db_resnet50 checkpoint #1840

wants to merge 1 commit into from

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • Add new db_resnet50 checkpoint (epoch 38)

@felixdittrich92 felixdittrich92 added topic: documentation Improvements or additions to documentation type: enhancement Improvement module: models Related to doctr.models benchmark This issue reports a benchmark framework: pytorch Related to PyTorch backend topic: text detection Related to the task of text detection ext: docs Related to docs folder labels Jan 15, 2025
@felixdittrich92 felixdittrich92 added this to the 0.11.0 milestone Jan 15, 2025
@felixdittrich92 felixdittrich92 self-assigned this Jan 15, 2025
felixdittrich92
felixdittrich92 commented Jan 15, 2025
View reviewed changes
doctr/models/detection/differentiable_binarization/pytorch.py
@@ -28,7 +28,7 @@
"input_shape": (3, 1024, 1024),
"mean": (0.798, 0.785, 0.772),
"std": (0.264, 0.2749, 0.287),
"url": "https://doctr-static.mindee.com/models?id=v0.7.0/db_resnet50-79bd7d70.pt&src=0",
"url": "https://github.com/mindee/doctr/releases/download/v0.10.0/db_resnet50-a5b57aac.pt",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odulcy-mindee url update :D

@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (b0d2728) to head (cbe7cf8).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1840      +/-   ##
==========================================
+ Coverage   96.58%   96.63%   +0.05%     
==========================================
  Files         165      165              
  Lines        7940     7940              
==========================================
+ Hits         7669     7673       +4     
+ Misses        271      267       -4
Flag Coverage Δ
unittests 96.63% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 removed the request for review from odulcy-mindee January 15, 2025 08:33
@felixdittrich92
Copy link
Contributor Author

Temp revert - after further testing some results are worse than the current

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@felixdittrich92 felixdittrich92

Labels
benchmark This issue reports a benchmark ext: docs Related to docs folder framework: pytorch Related to PyTorch backend module: models Related to doctr.models topic: documentation Improvements or additions to documentation topic: text detection Related to the task of text detection type: enhancement Improvement
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
1 participant
@felixdittrich92