Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixed CI pypi automatic publish upon release #153

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • removed CI to build conda since it cannot work for now as per [conda] Unable to make a conda build #113
  • fixed pypi upload job (renamed doctr to python-doctr before upload): each new release created on Github will trigger the publishing on pypi automatically

Any feedback is welcome!

@fg-mindee fg-mindee added topic: build Related to dependencies and build topic: ci Related to CI labels Mar 17, 2021
@fg-mindee fg-mindee added this to the 0.1.1 milestone Mar 17, 2021
@fg-mindee fg-mindee requested a review from charlesmindee March 17, 2021 11:21
@fg-mindee fg-mindee self-assigned this Mar 17, 2021
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #153 (80bb56c) into main (19a8667) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files          34       34           
  Lines        1165     1165           
=======================================
  Hits         1142     1142           
  Misses         23       23           
Flag Coverage Δ
unittests 98.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a8667...80bb56c. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnaks for the PR !

@charlesmindee charlesmindee merged commit c05c30c into main Mar 17, 2021
@charlesmindee charlesmindee deleted the ci-publish branch March 17, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build Related to dependencies and build topic: ci Related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants