Skip to content

Bump cargo-dist and settings for publishing in crate.io #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 16, 2024

Conversation

tomoyanonymous
Copy link
Collaborator

@tomoyanonymous tomoyanonymous commented Nov 14, 2024

Bumps cargo-dist to 0.25.

It looks that cargo-dist now uses dist-workspace.toml instead writing everything into Cargo.toml.

Also, I removed the line like {path = "../mimium-lang" } for in-workspace dependencies and uses {workspace = true} because cargo publish allows only explicitly versioned dependencies.

I refered to the egui's Cargo.toml.

@tomoyanonymous
Copy link
Collaborator Author

tomoyanonymous commented Nov 14, 2024

I'm wondering how can I include mimium-lang/lib/**.mmm in the release bundle.
cargo-dist has include option but it does not allow glob pattern.

https://opensource.axo.dev/cargo-dist/book/reference/config.html#include

Is it possible to include such asset with build.rs? In the first place, the people who installed mimium-cli with cargo install can not get such assets with the cargo-dist dependent bundling...

@tomoyanonymous
Copy link
Collaborator Author

Test publish:
https://crates.io/crates/mimium-lang

@yutannihilation
Copy link
Contributor

Is it possible to include such asset with build.rs? In the first place, the people who installed mimium-cli with cargo install can not get such assets with the cargo-dist dependent bundling...

Guessing from axodotdev/cargo-dist#193 (comment), it seems the recommendation is to include the whole directory instead of a glob.

Is it possible to include such asset with build.rs?

I think this is possible, but it might not be very obvious where such files should be installed.

@tomoyanonymous
Copy link
Collaborator Author

Hmm, it looks impossible to include assets for an application provided through cargo install. I'll take care only cargo-dist

rust-lang/cargo#11683 (comment)

@tomoyanonymous
Copy link
Collaborator Author

https://crates.io/users/tomoyanonymous

Finished test release on crate.io.
I could not use cargo release because there is limit for publishing multiple new crates at the same time.
I'll test bumping a version with cargo-release later.

@tomoyanonymous tomoyanonymous merged commit ac523c4 into dev Nov 16, 2024
6 checks passed
@tomoyanonymous tomoyanonymous deleted the feat-publish branch November 22, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants