Chore: Move helpers to its own repo #163
Conversation
facuspagnuolo
force-pushed
the
chore/remove_helpers
branch
from
e1c7454
to
58f7a10
Compare
|
Once the job is completed, the results will be available at https://prover.certora.com/output/50838/3a868b5baca64349bee9f0e794a60408?anonymousKey=5e1697f4ba3f87fc460d8687b918672ef8cef68d |
|
Once the job is completed, the results will be available at https://prover.certora.com/output/50838/022d4c653c12498ba731d2b1d789aa07?anonymousKey=1e5febde351e8c5736b6fa86eb81fbc0e090a344 |
facuspagnuolo
force-pushed
the
chore/remove_helpers
branch
from
25d58e2
to
b6ed417
Compare
|
Once the job is completed, the results will be available at https://prover.certora.com/output/50838/76f1a6a439de4b719c6b8d9d4a55f28d?anonymousKey=76989da6c3e4cde68b71c948fa991c2c92b9b232 |
|
Once the job is completed, the results will be available at https://prover.certora.com/output/50838/ab76666acabe4805a439401a3a1a0cc0?anonymousKey=ae71e9700c3d66670017c109f72735874ae0e421 |
|
Once the job is completed, the results will be available at https://prover.certora.com/output/50838/a6e8f7ecfafa4c0f91eff234f4ce5418?anonymousKey=216eebed2872a431c378771e4a165a6eafa16cca |
|
Once the job is completed, the results will be available at https://prover.certora.com/output/50838/ada97fbf57554ed085a0b3e539750235?anonymousKey=1962745cae34dd833db5b1e252e2b9f7f861ff40 |
|
Once the job is completed, the results will be available at https://prover.certora.com/output/50838/cb6bff1c8a764f4ebba3b735184d00b3?anonymousKey=509a138ade507090f34074f92fd52b03b36dd560 |
|
Once the job is completed, the results will be available at https://prover.certora.com/output/50838/e1a698e1946747d1b62cf24702486980?anonymousKey=225dc1fa3b761074211f089c68a0ba2d289d51e1 |
|
Some prover rules are not passing, which seems to be due to timeouts. I think we should ignore them for now. |
There was a problem hiding this comment.
price oracle's integration test was successful in the last run, so why remove it?
There was a problem hiding this comment.
In general running fork tests in the CI I think it's a bad idea, I would love to have those if we find a way of not having issues with them
There was a problem hiding this comment.
I would skip the failing tests instead of removing all of them from the CI
There was a problem hiding this comment.
These are actually flaky, it's not predictable which ones fail
https://github.com/mimic-fi/helpers