Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks: Implement BPT exiter #115

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Conversation

lgalende
Copy link
Contributor

No description provided.

@lgalende lgalende self-assigned this Oct 22, 2023
Copy link
Member

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things that need to be fixed but adding the tests will help you solving them. I suggest I commit my review after that

Copy link
Member

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Member

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facuspagnuolo facuspagnuolo merged commit 6c59d57 into master Oct 24, 2023
3 checks passed
@facuspagnuolo facuspagnuolo deleted the tasks/implement_bpt_exiter branch October 24, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants