Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks: Implement new time lock modes #104

Merged
merged 9 commits into from
Oct 19, 2023

Conversation

facuspagnuolo
Copy link
Member

@facuspagnuolo facuspagnuolo commented Oct 3, 2023

⚠️ I still need to fix contract bytecode size

This PR aims to provide new modes for timelocks, the alternatives now are:

  • waiting at least X seconds between executions, no matter when
  • waiting at least X seconds between executions, starting on date Y, with an execution window Z
  • occurring every X months, on day Y, with an execution window Z
  • occurring every X months, on last day of month, with an execution window Z

@facuspagnuolo facuspagnuolo self-assigned this Oct 3, 2023
@facuspagnuolo facuspagnuolo force-pushed the tasks/implement_new_timelock_modes branch 2 times, most recently from fb8c651 to a17b43d Compare October 11, 2023 04:32
@facuspagnuolo facuspagnuolo marked this pull request as ready for review October 11, 2023 04:32
@facuspagnuolo facuspagnuolo force-pushed the tasks/implement_new_timelock_modes branch from a17b43d to cc12807 Compare October 14, 2023 03:03
@mimic-fi mimic-fi deleted a comment from github-actions bot Oct 14, 2023
@mimic-fi mimic-fi deleted a comment from github-actions bot Oct 14, 2023
@facuspagnuolo facuspagnuolo force-pushed the tasks/implement_new_timelock_modes branch from cc12807 to e07dd58 Compare October 14, 2023 03:06
@mimic-fi mimic-fi deleted a comment from github-actions bot Oct 14, 2023
@facuspagnuolo facuspagnuolo force-pushed the tasks/implement_new_timelock_modes branch from e07dd58 to e2450d2 Compare October 16, 2023 10:04
@github-actions
Copy link

@mimic-fi mimic-fi deleted a comment from github-actions bot Oct 17, 2023
@mimic-fi mimic-fi deleted a comment from github-actions bot Oct 17, 2023
@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@facuspagnuolo facuspagnuolo merged commit 2c92a19 into master Oct 19, 2023
6 checks passed
@facuspagnuolo facuspagnuolo deleted the tasks/implement_new_timelock_modes branch October 19, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants