Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Named Wallets #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sheldonth
Copy link

@sheldonth sheldonth commented Sep 29, 2021

This RFC defines a system for grin wallet to support multiple wallets in the root wallet directory. The basis of the document text is an old closed PR by @yeastplume with some extra definition added to modernize the proposal to the current wallet Owner API.

Rendered Text

Any and all feedback appreciated.

@Anynomouss
Copy link

@sheldonth
You should check these forum posts, they are very much related to this RFC:
https://forum.grin.mw/t/grin-hd-wallet-one-time-use-addresses-rfc/9028
https://forum.grin.mw/t/withdrewed-request-for-funding-davidtavarez-one-time-use-slatepack-addresses-for-wallet-rfc-and-grin-implementation/8707/44
https://forum.grin.mw/t/lets-create-the-ultimate-grin-wallet-experience-grin-ux-ui/9092

This overlaps with some ideas from @davidtavarez. The funding request was cancelled because the timing was not right, but there is a widespread support for this idea and as such possibility for funding can be discussed 😀

@phyro
Copy link
Member

phyro commented Oct 2, 2021

Thanks for starting this. I think this looks good 👍

@Anynomouss
Copy link

Anynomouss commented Oct 20, 2021

I checked the RFC, looks good to me. And yes, I think the benefits of having this option outweighs the downside of having added complexity.
Would be nice to combine your work directly with additional implementation of one-time use adressess and multiple accounts, but could also be separate since having multi-wallet support is a good step forward anyhow.

Just a thought, would it be better to have a global grin-server.toml file as well as a local grin-server.toml per wallet where users can have separate settings? I have not plaid around much with grin-walllet so this is an open question that might be better answered by those who want to use multiple wallets for various reasons, e.g. exchanges.
Also, we might need to have such a local grin-server.toml file if we want to implement one-time use addresses. We might want to store settings and configurations for having multiple accounts and settings per account in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants