Skip to content

fix: [2.5] Reset compacting when finishing segment stats #42005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #41963
Related to #41962

@sre-ci-robot sre-ci-robot requested review from cydrain and sunby May 21, 2025 15:43
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 21, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 21, 2025
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.64%. Comparing base (00336a8) to head (f8d9855).
Report is 31 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #42005   +/-   ##
=======================================
  Coverage   80.63%   80.64%           
=======================================
  Files        1427     1427           
  Lines      205253   205255    +2     
=======================================
+ Hits       165513   165527   +14     
+ Misses      33920    33911    -9     
+ Partials     5820     5817    -3     
Components Coverage Δ
Client 79.42% <ø> (ø)
Core 70.67% <ø> (ø)
Go 82.60% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/task_stats.go 87.41% <100.00%> (+0.08%) ⬆️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label May 22, 2025
Copy link
Collaborator

@czs007 czs007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0393fec into milvus-io:2.5 May 30, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants