-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix: Fix sync segments failed due to OOM check in segment loader #41985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@weiliu1031 E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41985 +/- ##
==========================================
- Coverage 81.67% 80.45% -1.22%
==========================================
Files 1202 1537 +335
Lines 185973 216703 +30730
==========================================
+ Hits 151886 174358 +22472
- Misses 27803 36053 +8250
- Partials 6284 6292 +8
🚀 New features to boost your workflow:
|
f9a3a6f
to
9a61f66
Compare
@weiliu1031 E2e jenkins job failed, comment |
9a61f66
to
5540dc5
Compare
@weiliu1031 cpp-unit-test check failed, comment |
Fix the issue where segment loading fails unnecessarily due to incorrect memory and disk usage checks. Changes include: - Only perform OOM check when there's actual memory/disk cost during segment loading - Skip checks when setting segments to delegator doesn't consume resources - Rename variables for better readability (maxSegmentSize -> maxSegmentMemSize) - Enhance test cases to cover more scenarios with memory and disk usage settings Signed-off-by: Wei Liu <[email protected]>
5540dc5
to
83920e2
Compare
sync segment may cost a few memory by delta log, so this pr won't fix the issue |
issue: #41984
Fix the issue where segment loading fails unnecessarily due to incorrect memory and disk usage checks. Changes include: