-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple documents #768
base: master
Are you sure you want to change the base?
Add support for multiple documents #768
Conversation
Looking at the test failures, seems like we need a patched version of QT for this. 🤔 |
2a3be0f
to
79ff029
Compare
Great! This seems very useful, especially for cover pages etc! But it'll likely need to be a bit more involved to be something like this: sudo apt-get install -y libqt5webkit5-dev libqt5xmlpatterns5-dev libqt5svg5-dev &&
wget https://downloads.wkhtmltopdf.org/0.12/0.12.5/wkhtmltox_0.12.5-1.bionic_amd64.deb &&
sudo dpkg -i wkhtmltox_0.12.5-1.bionic_amd64.deb &&
sudo apt-get install -f BTW, there's a lot of cool stuff in the |
03b5460
to
4eb9f89
Compare
4eb9f89
to
7de447a
Compare
@unixmonkey I've updated the PR by adding wkhtmltopdf with patched-qt. |
I think it's high time to drop support for 1.8.7. If someone still on that platform needs this, I think it's safe to assume they are ok pinning to an existing version or writing their own patches. Doing this officially should be a major version bump though. Since this is a development-only dependency requirement right now, let's move 1.8.7 to allowed failures. |
Hi! Is this cool feature going to be merged?? |
Would love to see this feature added. |
wkhtmltopdf
supports downloading multiple html documents and combining them into a single pdf.WickedPdf doesn't support it right now.
This PR adds this support. It introduces two new interfaces.
WickedPdf#pdf_from_multiple_strings
WickedPdf#pdf_from_multiple_html_files
While keeping the existing interfaces as it is.