Merge downstream forks into a unified simplified kernel module and Python userland that supports multiple generations. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed .gitignore
…ex values if the values arent sparse and correspond 1 to 1 to list index.
… added bound by a debug option in the kernel module and not on by default.
Fix kernel module compiling on different versions, first pass of Python userland, disable logging noise
* Add support for new NUC 10 LED type which has changed the LED type for HDD LED and enabled control of the internal RGB Header. * Add linter cleanups.
… value processing after feedback from Intel on issues with new NUC 10 BIOS. - Refactor the code to more cleanly outline where we are using bitmaps vs indexes. - Expand unit tests to use values with higher bit numbers where the bit index would significantly differ in value from the list index.
…dly labels instead of internal WMI hex values.
…ction branch test its own unit test function.
…tory fresh state.
…driver since the NUC WMI supports more than just the LED on some models.
…spec values, switch to nuc_wmi control file, and add lock file support for CLI commands to prevent overlapping control file use.
…e Python 2 version to avoid conflicts.
… configuration in an attempt to add NUC 12 support, drop Python 2 support.
… from being included in sdist.
…oard Add NUC 10 LED header breakout board schematic.
Initial release of NUC WMI 3.0: replace quirks mode with NUC WMI spec configuration in an attempt to add NUC 12 support, drop Python 2 support.
nuc_wmi 2.0 driver and nuc_wmi 3.0 userland with better error handling, quirks mode replaced with WMI spec confg file, NUC 12 support, and lock file support
…either in kernel or the kernel module itself) on 5.x kernels in Ubuntu 20.04/22.04 which causes the kernel to kill the Python userland when reading from the control file.
…UC WMI lock file.
…e the number of WMI calls that need to be done.
… Disable indicator option in the query_led_indicator_options response in BIOS that do not honor the spec.
Add lock file blocking acquisition, performance improvements, and new recover option
Refactor and re-organize the NUC WMI spec JSON schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges downstream forks which simplifies the nuc_wmi kernel module into a bare bones RPC interface and uses Python userland as interface to send the WMI commands in a human/machine readable fashion while also providing support across multiple distros/kernels and NUC generations.
Currently tested on Ubuntu 18.04/22.04 on NUC 7, 10 and 12.