Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiles and Parameters update #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

xptsp
Copy link

@xptsp xptsp commented Feb 24, 2019

  1. Refactored code to add boot, shutdown, suspend, wake, hibernate, restore, recording, and voice profiles.

  2. Added nuc_led_profiles parameter to the module to allow mass setting of all profiles at module load time.

  3. Added debug parameter to allow calls to dmesg to indicate which parameter is invalid.

  4. Added hibernate_same parameter to tell the module to treat hibernation and suspension events seperately or the same.

  5. Added code to add current to each setting so that profiles can specify a particular setting to change (ie: brightness) without affecting other settings.

  6. Added code to allow use of numbers instead of labels (ie: power, blink_fast, etc) in order to allow for shorter strings when passing all profiles to the module at one time.

  7. Modified Makefile so that dkms.conf is updated with version number in Makefile before building.

  8. Modified acpi_write_read to use internal buffer for its playpen, instead of allocating seperate memory. Also implemented process blocking code to avoid unwanted buffer corruption.

  9. Updated README.md with a ton of new information pertaining to the modifications I've made to the code.

1) Refactored code to add  `boot`, `shutdown`, `suspend`, `wake`, `hibernate`, `restore`, `recording`, and `voice` profiles.

2) Added `nuc_led_profiles` parameter to the module to allow mass setting of all profiles at module load time.

3) Added `debug` parameter to allow calls to dmesg to indicate which parameter is invalid.

4) Added `hibernate_same` parameter to tell the module to treat hibernation and suspension events seperately or the same.

5) Added code to add `current` to each setting so that profiles can specify a particular setting to change (ie: brightness) without affecting other settings.

6) Added code to allow use of numbers instead of labels (ie: `power`, `blink_fast`, etc) in order to allow for shorter strings when passing all profiles to the module at one time.

7) Modified `Makefile` so that `dkms.conf` is updated with version number in `Makefile` before building.

8) Modified `acpi_write_read` to use internal buffer for its playpen, instead of allocating seperate memory.  Also implemented process blocking code to avoid unwanted buffer corruption.

9) Updated `README.md` with a ton of new information pertaining to the modifications I've made to the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant