Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test #262

Closed
wants to merge 8 commits into from
Closed

Test #262

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .arduino-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@ compile:
# Choosing to run compilation tests on 2 different Arduino platforms
platforms:
- uno
- due
# - due
# - zero # SAMD covered by M4
# - leonardo # AVR covered by UNO
- m4
# - m4
# - esp32 # errors on OneWire => util/crc16.h vs rom/crc.h
- esp8266
# - esp8266
# - mega2560 # AVR covered by UNO
unittest:
# These dependent libraries will be installed
libraries:
- "Arduino"
- "OneWire"
6 changes: 3 additions & 3 deletions .github/workflows/arduino-lint.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@

name: Arduino-lint

on: [push, pull_request]
jobs:
lint:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: arduino/arduino-lint-action@v1
with:
library-manager: update
# compliance: strict
compliance: strict
4 changes: 2 additions & 2 deletions .github/workflows/arduino_test_runner.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
---
name: Arduino CI

on: [push, pull_request]

jobs:
runTest:
runs-on: ubuntu-latest
timeout-minutes: 20

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: 2.6
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/jsoncheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ on:
jobs:
test:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: json-syntax-check
uses: limitusus/json-syntax-check@v1
uses: limitusus/json-syntax-check@v2
with:
pattern: "\\.json$"

pattern: "\\.json$"
4 changes: 2 additions & 2 deletions DallasTemperature.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,7 @@ int32_t DallasTemperature::calculateTemperature(const uint8_t* deviceAddress,
// the numeric value of DEVICE_DISCONNECTED_RAW is defined in
// DallasTemperature.h. It is a large negative number outside the
// operating range of the device
int32_t DallasTemperature::getTemp(const uint8_t* deviceAddress, byte retryCount = 0) {
int32_t DallasTemperature::getTemp(const uint8_t* deviceAddress, byte retryCount) {

ScratchPad scratchPad;

Expand All @@ -742,7 +742,7 @@ int32_t DallasTemperature::getTemp(const uint8_t* deviceAddress, byte retryCount
// the numeric value of DEVICE_DISCONNECTED_C is defined in
// DallasTemperature.h. It is a large negative number outside the
// operating range of the device
float DallasTemperature::getTempC(const uint8_t* deviceAddress, byte retryCount = 0) {
float DallasTemperature::getTempC(const uint8_t* deviceAddress, byte retryCount) {
return rawToCelsius(getTemp(deviceAddress, retryCount));
}

Expand Down
8 changes: 5 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
[![Arduino CI](https://github.com/milesburton/Arduino-Temperature-Control-Library/workflows/Arduino%20CI/badge.svg)](https://github.com/marketplace/actions/arduino_ci)
[![Arduino-lint](https://github.com/milesburton/Arduino-Temperature-Control-Library/actions/workflows/arduino-lint.yml/badge.svg)](https://github.com/RobTillaart/AS5600/actions/workflows/arduino-lint.yml)
[![JSON check](https://github.com/milesburton/Arduino-Temperature-Control-Library/actions/workflows/jsoncheck.yml/badge.svg)](https://github.com/RobTillaart/AS5600/actions/workflows/jsoncheck.yml)
[![Arduino-lint](https://github.com/milesburton/Arduino-Temperature-Control-Library/actions/workflows/arduino-lint.yml/badge.svg)](https://github.com/milesburton/Arduino-Temperature-Control-Library/actions/workflows/arduino-lint.yml)
[![JSON check](https://github.com/milesburton/Arduino-Temperature-Control-Library/actions/workflows/jsoncheck.yml/badge.svg)](https://github.com/milesburton/Arduino-Temperature-Control-Library/actions/workflows/jsoncheck.yml)
[![GitHub issues](https://img.shields.io/github/issues/milesburton/Arduino-Temperature-Control-Library.svg)](https://github.com/milesburton/Arduino-Temperature-Control-Library/issues)

[![License: MIT](https://img.shields.io/badge/license-MIT-green.svg)](https://github.com/milesburton/Arduino-Temperature-Control-Library/blob/master/LICENSE)
[![GitHub release](https://img.shields.io/github/release/milesburton/Arduino-Temperature-Control-Library.svg?maxAge=3600)](https://github.com/milesburton/Arduino-Temperature-Control-Library/releases)

[![Commits since latest](https://img.shields.io/github/commits-since/milesburton/Arduino-Temperature-Control-Library/latest)](https://github.com/milesburton/Arduino-Temperature-Control-Library/commits/master)

# Arduino Library for Maxim Temperature Integrated Circuits

Expand Down
4 changes: 3 additions & 1 deletion library.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
"paulstoffregen/OneWire": "^2.3.5"
},
"version": "3.11.0",
"license": "GNU",
"frameworks": "arduino",
"platforms": "*"
"platforms": "*",
"headers": "DallasTemperature.h"
}
File renamed without changes.