added collections.abc import #36
Conversation
alchemy_mock/comparison.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| # -*- coding: utf-8 -*- | |||
| from __future__ import absolute_import, print_function, unicode_literals | |||
| import collections | |||
| import collections.abc | |||
There was a problem hiding this comment.
The library still support Python 2. Mapping is available through collections. So the fix would be to import Mapping from collections on Python 2 and collections.abc to be used for Python 3 as mentioned in the bug ticket.
try:
# try collections.abc for Python 3.4+
from collections.abc import Mapping
except ImportError:
# fallback to collections for Python 2 compatibility.
from collections import Maping
six already supports this move as from six.moves.collections_abc import Mapping from benjaminp/six@0dc54ea (six 1.13.0)
|
I just saw this deprecation notice now, I hope this gets merged |
|
Deprecation was changed to python 3.9 which came out last week. This PR is simple but still more than 3 months old. Given no changes were made to this project in the last year, anyone else think this project is no longer supported? |
|
Any word on this? I really like alchemy-mock and would love to keep using it. |
|
Bumping almost 2 years later, my team is exclusively on 3.10 now and we can't use alchemy-mock like this |
|
another bump |
|
On Python 3.11 now, bypassing the issue by updating the local package, but would be great to get this merged. |
|
I've switched to |
This is to fix this issue
#35