Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make install #48

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Add make install #48

merged 1 commit into from
Jun 24, 2024

Conversation

alichtman
Copy link
Contributor

It would be nice to be able to install this to /usr/local/bin easily.

@alichtman alichtman changed the title Add make install Add make install Jun 23, 2024
@mikesart mikesart merged commit a910fe4 into mikesart:master Jun 24, 2024
5 checks passed
@mikesart
Copy link
Owner

Thanks Aaron!

@motiejus
Copy link
Collaborator

motiejus commented Jun 24, 2024

I think it should default to /usr/bin and honor $PREFIX, then distros can use this target too.

@alichtman
Copy link
Contributor Author

alichtman commented Jun 24, 2024

/usr/bin is for distro-managed binaries, so having $ make install put it there would be incorrect, and may break unexpectedly in the future. https://unix.stackexchange.com/a/8658

I think installing the binary here would have to be a decision made by package maintainers for each distro (and another target could be created for distros to use, like make install-for-distro).

On the $PREFIX suggestion -- I found https://www.gnu.org/software/make/manual/make.html#Directory-Variables to explain it. That seems reasonable to me.

@motiejus
Copy link
Collaborator

On the $PREFIX suggestion -- I found https://www.gnu.org/software/make/manual/make.html#Directory-Variables to explain it. That seems reasonable to me.

Can you make a follow up PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants