Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed header/footer option for Chrome 120 #42

Merged
merged 4 commits into from
Dec 12, 2023
Merged

changed header/footer option for Chrome 120 #42

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41d3b7e
changed header/footer option for Chrome 120
alpaca1thunder Dec 12, 2023
d665330
Revert "changed header/footer option for Chrome 120"
alpaca1thunder Dec 12, 2023
4b49621
Keep both versions of this option for backwards compatibility, https:…
alpaca1thunder Dec 12, 2023
3262f49
Proper python comment for the pdf header issue
alpaca1thunder Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions resume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ def write_pdf(html: str, prefix: str = "resume", chrome: str = "") -> None:
"--no-sandbox",
"--headless",
"--print-to-pdf-no-header",
alpaca1thunder marked this conversation as resolved.
Show resolved Hide resolved
"--no-pdf-header-footer",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep both versions of this option for backwards compatibility, https://developer.chrome.com/docs/chromium/new-headless.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm asking for a Python comment, i.e. a line starting with #, in the diff itself. Not a comment on github.com.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sorry again for the confusion. Should be in the latest commit.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set. Thank you for the contribution!

"--enable-logging=stderr",
"--log-level=2",
"--in-process-gpu",
Expand Down
Loading