remove do catch #12
Merged
remove do catch #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeger
approved these changes
Dec 14, 2023
|
Hey @swwol , thanks so much for your contribution! This is the first external contribution to this repo. I will add you to the list of authors if you have nothing against it. |
|
By the way, in case you are seeing any specific other errors that need to be resolved feel free to open an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
do catcharound thetool.runcommand.This was allowing the tool to fail silently on the CI and then the workflow step only ends when it timed out.
If the error is actually thrown, the process will exit with an error code instead.