-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy support #519
Proxy support #519
Conversation
app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsAdvancedScreen.kt
Outdated
Show resolved
Hide resolved
I did some thinking and how likely is it that average user will use a proxy? This feature will probably be used by <0.01% of users. Most will probably install some free vpn and use that. Though the feature is simple to implement do we really want another option that will not be used by most of the user base? |
Mainly because it's annoying work to add those domain rules in rule-based proxy app, and didn't want to use global proxy to affect some other apps (some app will ban account or mark account for ip change frequently). Especially some sources have several domains and cdn or change domain/redirect for some reason. Of course, only few people need this function, may people just open global vpn when they read. |
Closing based on my rationale |
Closes #366
Implemented proxy support.
This is what the dialog looks like: