Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy support #519

Closed
wants to merge 12 commits into from
Closed

Proxy support #519

wants to merge 12 commits into from

Conversation

Shamicen
Copy link
Contributor

Closes #366

Implemented proxy support.

This is what the dialog looks like:

@AntsyLich
Copy link
Member

I did some thinking and how likely is it that average user will use a proxy? This feature will probably be used by <0.01% of users. Most will probably install some free vpn and use that. Though the feature is simple to implement do we really want another option that will not be used by most of the user base?

@La-Hire
Copy link

La-Hire commented Apr 21, 2024

I did some thinking and how likely is it that average user will use a proxy? This feature will probably be used by <0.01% of users. Most will probably install some free vpn and use that. Though the feature is simple to implement do we really want another option that will not be used by most of the user base?

Mainly because it's annoying work to add those domain rules in rule-based proxy app, and didn't want to use global proxy to affect some other apps (some app will ban account or mark account for ip change frequently). Especially some sources have several domains and cdn or change domain/redirect for some reason.

Of course, only few people need this function, may people just open global vpn when they read.

@AntsyLich
Copy link
Member

Closing based on my rationale

@AntsyLich AntsyLich closed this May 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for proxies (Socks5 if possible) per extension based or app based.
3 participants