Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add per-extension incognito mode #157

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

sdaqo
Copy link

@sdaqo sdaqo commented Jan 20, 2024

This PR adds a per-extension incognito mode toggle. With this you can more or less "automate" using the incognito mode as oftentimes there are only specific extensions (heh) where you need it.

Image

Screenshot_20240120_132036

@AntsyLich
Copy link
Member

You need to consider the fact that source can change id and extensions can also have new source

@sdaqo

This comment was marked as outdated.

@sdaqo
Copy link
Author

sdaqo commented Jan 21, 2024

I guess removing the sources from the list when the extension is uninstalled is also a good idea, else we would have a bunch of orphan source ids that do not belong to any extension.

@sdaqo
Copy link
Author

sdaqo commented Apr 23, 2024

Bumping, because I wanted to know if there is anything you want me to do else, or if this is only stalled because you want to implement other stuff before this.

@federicogith
Copy link

Since I find this feature really useful and timesaving, @MajorTanya is there any reason why this is stalled?

@MajorTanya
Copy link
Contributor

Since I find this feature really useful and timesaving, @MajorTanya is there any reason why this is stalled?

First: please don't ping random people into PRs, especially when they have not even been there before.

Second: I have no control over what gets accepted or not, and there may be any number of reasons for stuff to be stalled. You coming in to necropost is neither helping nor welcome. No, this is not an invitation to ping AntsyLich instead or anything else.

Either it will be accepted at some point or it won't. Until such time, you'll have to wait.

Copy link
Member

@AntsyLich AntsyLich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally instead of saving each source ids we could potentially resolve the IDs whenever we initialize an extension? Something like a new class that listens for changes in available extensions filters them by incognito disabled extension and maps to the IDs of sources inside them.

address change requests
@sdaqo
Copy link
Author

sdaqo commented Nov 1, 2024

Additionally instead of saving each source ids we could potentially resolve the IDs whenever we initialize an extension? Something like a new class that listens for changes in available extensions filters them by incognito disabled extension and maps to the IDs of sources inside them.

Honestly I do not quite know what exactly you mean by this...
I think the current solution is fine, your suggestions seems rather complex, but maybe I am just not comfortable enough with the codebase yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants