fix: app update error notification always disappeared #1476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce the issue
network.client.callTimeout
to just 1-3 seconds.Expect
Download Error
notification should be shown after theDownloading
notification hides.Actual
Downloading
notification hides and there are no more notification.Reason
AppUpdateDownloadJob
foreground is set tied toNotifications.ID_APP_UPDATER
Download Error
notification also useNotifications.ID_APP_UPDATER
- debug shows that it is actually called to showNotifications.ID_APP_UPDATER
is closed and hence clearing theDownload Error
notification.