Trim whitespace from Repo URL and lowercase it #1393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntsyLich
reviewed
Oct 28, 2024
domain/src/main/java/mihon/domain/extensionrepo/interactor/CreateExtensionRepo.kt
Outdated
Show resolved
Hide resolved
This should close mihonapp#1392.
In accordance with RFC 3986, only the scheme and host are case-insensitive. Therefore we're only replacing the scheme with its guaranteed in-lowercase version.
cuong-tran
pushed a commit
to komikku-app/komikku
that referenced
this pull request
Nov 1, 2024
Closes mihonapp/mihon#1392 Closes mihonapp/mihon#1393 (cherry picked from commit 22d8aad)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #1392.
Trimming whitespace and lowercasing the URL isn't an invasive procedure on the URL itself, and helps users who may have accidentally copied a space, or somehow capitalised or uppercased the URL because of an overzealous autocorrect, etc.