-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library Update Errors Screen #1381
base: main
Are you sure you want to change the base?
Conversation
7e3ee1b
to
531539b
Compare
|
||
@OptIn(ExperimentalStdlibApi::class) | ||
@Composable | ||
fun FailedUpdatesBottomActionMenu( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be in presentation/updates/components...
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well yeah probably, just did a 1-1 migration and did the least possible changes to get it to build. I'll look into specifics soon. (Probably should turn this into a draft but 🤷♂️)
add more screenshot pls, I saw 1 in Discord, this looks nice |
Here ya go. Was just too lazy to censor stuff while half asleep. 🤣 Screen_Recording_20241027_063400_Mihon_1.mp4 |
c33a3a7
to
b43b0f8
Compare
should close this #132 |
b43b0f8
to
5dad063
Compare
Co-Authored-By: Programmer-0-0 <[email protected]>
5dad063
to
c6a2947
Compare
00d99e3
to
17d9e47
Compare
Migrated PR from Tachiyomi#9795
Closes #132
Things left to do
Elaboration
Key was already used crash
SELECT * FROM mangas WHERE _id = 77;
DELETE * FROM mangas WHERE _id = 77;
Could just be that I had a slightly corrupted DB but who knows
ExtendedFloatingActionButton
These don't seem to exist anymore, so the fab is always extended.
Fractions Error
Seems to be caused by Multi Language Extentions.
Eg. Ext-ENG had 16 entries with 16 failed. Ext-Multi has 4 entries with 4 failed. The fails of multi get added to the ENG without it updating the total count showing 20/16
All failed updates gets reset on new update
Triggering any category update at all, wipes the log of errors.
Ideally it should only reset for a manga when that manga is updated again.
Eg. You have 50 entries with errors. you update a category with 1 entry in it. All error logs gets reset.