Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Update Errors Screen #1381

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Animeboynz
Copy link
Contributor

@Animeboynz Animeboynz commented Oct 26, 2024

Migrated PR from Tachiyomi#9795

Closes #132

Things left to do

  • Null Crash on Untrusted Extensions
  • Add icons for untrusted extensions
  • Investigate key was already used crash
  • Revisit ExtendedFloatingActionButton
  • i18n of Exception Strings
  • Questionable Fractions
  • All failed updates gets reset on new update

Elaboration

Key was already used crash

  • Consistently kept happening,
  • Ran SELECT * FROM mangas WHERE _id = 77;
  • There was only one result
  • Ran DELETE * FROM mangas WHERE _id = 77;
  • It fixed itself

Could just be that I had a slightly corrupted DB but who knows

ExtendedFloatingActionButton

These don't seem to exist anymore, so the fab is always extended.

import tachiyomi.presentation.core.util.isScrolledToEnd
import tachiyomi.presentation.core.util.isScrollingUp
floatingActionButton = {
      AnimatedVisibility(
          visible = state.items.isNotEmpty(),
          enter = fadeIn(),
          exit = fadeOut(),
      ) {
          ExtendedFloatingActionButton(
              text = { Text(text = stringResource(R.string.label_help)) },
              icon = { Icon(imageVector = Icons.Outlined.HelpOutline, contentDescription = null) },
              onClick = { uriHandler.openUri("https://tachiyomi.org/help/guides/troubleshooting") },
              //expanded = failedUpdatesListState.isScrollingUp() || failedUpdatesListState.isScrolledToEnd(),
          )
      }
},

Fractions Error

Seems to be caused by Multi Language Extentions.

Eg. Ext-ENG had 16 entries with 16 failed. Ext-Multi has 4 entries with 4 failed. The fails of multi get added to the ENG without it updating the total count showing 20/16

All failed updates gets reset on new update

Triggering any category update at all, wipes the log of errors.

Ideally it should only reset for a manga when that manga is updated again.

Eg. You have 50 entries with errors. you update a category with 1 entry in it. All error logs gets reset.

@Animeboynz Animeboynz force-pushed the UpdateErrorsScreen branch 8 times, most recently from 7e3ee1b to 531539b Compare October 26, 2024 11:07
@AntsyLich AntsyLich mentioned this pull request Oct 26, 2024

@OptIn(ExperimentalStdlibApi::class)
@Composable
fun FailedUpdatesBottomActionMenu(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be in presentation/updates/components...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well yeah probably, just did a 1-1 migration and did the least possible changes to get it to build. I'll look into specifics soon. (Probably should turn this into a draft but 🤷‍♂️)

@cuong-tran
Copy link
Contributor

add more screenshot pls, I saw 1 in Discord, this looks nice

@Animeboynz
Copy link
Contributor Author

add more screenshot pls, I saw 1 in Discord, this looks nice

Here ya go. Was just too lazy to censor stuff while half asleep. 🤣
It is supposed to say the error reason under the title when ungrouped but string need to be fixed.

Screen_Recording_20241027_063400_Mihon_1.mp4

@Animeboynz Animeboynz force-pushed the UpdateErrorsScreen branch 2 times, most recently from c33a3a7 to b43b0f8 Compare October 26, 2024 23:05
@cuong-tran
Copy link
Contributor

should close this #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In app Error list for chapter update errors
2 participants