Add Quantity Badge to Upcoming Screen #1250
Open
+60
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Animeboynz
force-pushed
the
Upcoming-Screen-Modifications
branch
from
7dfe77a
to
0520de9
Compare
Animeboynz
force-pushed
the
Upcoming-Screen-Modifications
branch
from
0520de9
to
04f2609
Compare
AntsyLich
reviewed
Sep 28, 2024
Comment on lines
178
to
184
| val mangaCount = items.filterIsInstance<UpcomingUIModel.Item>() | ||
| .count { it.manga.expectedNextUpdate?.toLocalDate() == item.date } | ||
|
|
||
| DateHeading( | ||
| date = item.date, | ||
| mangaCount = mangaCount, | ||
| ) |
There was a problem hiding this comment.
This calculation should be done inside the screen model. If we do this in the UI the calculation will need to run again after the UI element goes off screen (plus some more).
There was a problem hiding this comment.
IDK if what I did is what you meant but we will see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1227