-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] remove unnecessary external storage permission #1453
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # CHANGELOG.md # android/src/main/java/com/mr/flutter/plugin/filepicker/FilePickerDelegate.java # pubspec.yaml
Great job! Removing unnecessary privacy permissions is definitely user-friendly. @miguelpruivo , could you take a look at this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Pluxury before merging, have you tested in older SDKs such as 21? |
Unfortunately, no. There is no way to do this now, but judging by the documentation, there should be no problems |
Can this pull request be merged? @miguelpruivo |
Can you please resolve the conflicts? |
In this PR, I have removed everything related to the request for access to external storage. Permission is not required for the plugin to work correctly on android.
This was also discussed in #872
I have tested it on several emulators from API 27 to API 33
P.S I'm sorry, I accidentally deleted the previous PR that was here