Remove associated Velero Backups after BSL removal #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpryc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
- adds label to the Velero Backup object from the origin NaBSL - cleans up the Velero Backup objects with the associated label Signed-off-by: Michal Pryc <[email protected]>
mpryc
force-pushed
the
delete_velero_backup_nabsl
branch
from
5e6e206 to
04e9f0d
Compare
|
After looking how this works, I think this PR is wrong. The NaBSL removal should trigger Non Admin Backup removals and not the Velero Backup removals. Then Non Admin Backup controller responsibility is to remove the Velero Backup from the |
|
/hold |
|
Closing as the implementation in the #163 is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes were made
Removal of the Backup objects after NaBSL removal should happen from the non admin BSL reconcile.
If there are any left-overs GC should take action, so the GC controller should be independent of this logic.
Responsibility to clean up Non Admin Backups when the Velero Backups objects are removed is GC.
How to test the changes made