Fix "cannot range over" local lint errors #126
Conversation
Fix for the "cannot range over" that bumps the golang-ci version Makes simila range loop in the nab controller. Signed-off-by: Michal Pryc <[email protected]>
|
@kaovilai FYI |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Updates the link to the used documentation reference Signed-off-by: Michal Pryc <[email protected]>
|
Why did I not have issue with 1.56.2 tho.. 🤷 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mateusoliveira43, mpryc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Michal's executable was built with go 1.21, mine and yours with 1.22 |
|
Too bad.. I think you should avoid using go install for linters.. that would solve this issue . That meant this PR is no-op. |
|
perhaps the makefile should set GOTOOLCHAIN, and only then can the |
|
/lgtm |
Fix for the "cannot range over" that bumps the golang-ci version Makes simila range loop in the nab controller.
Why the changes were made
To fix local $ make lint errors introduced with #122
New version of golang-ci is fixing the issue on local ran.
How to test the changes made
ran the lint after change, no error appeared.
This PR is similar to #124, but uses different approach, so one or other should be merged.