Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Import OADP label from OADP #121

Conversation

mateusoliveira43
Copy link
Contributor

Why the changes were made

Use value from OADP instead of defining it.

How to test the changes made

Check CI logs.

Copy link

openshift-ci bot commented Nov 29, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Collaborator

@mpryc mpryc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change.

Signed-off-by: Mateus Oliveira <[email protected]>
@mateusoliveira43 mateusoliveira43 force-pushed the fix/import-oadp-label-from-oadp branch from 31769ec to 7f26f9e Compare December 4, 2024 19:33
@mateusoliveira43 mateusoliveira43 marked this pull request as ready for review December 4, 2024 19:34
@openshift-ci openshift-ci bot requested review from mpryc and sseago December 4, 2024 19:34
Copy link

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,mateusoliveira43,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaovilai
Copy link
Member

kaovilai commented Dec 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f114599 into migtools:master Dec 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants