Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storybook): switch Storybook deployment from GitHub Pages to Surge to avoid DNS issues #70

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Jul 1, 2021

Our Storybook docs were originally deployed to konveyor.github.io/lib-ui, which now redirects to konveyor.io/lib-ui. This worked for a while, but has since become a 404 now that the new konveyor.io website has been published.

We could figure this out and restore the usage of either konveyor.io or github.io later, but the audience for these docs is internal and small and I don't think it's necessarily worth the effort. This PR gets our docs back online by moving our main Storybook deployment to Surge, like our PR previews. The new URL is http://konveyor-lib-ui.surge.sh/.

@mturley mturley requested a review from a team July 1, 2021 18:51
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #70 (8dcbd8a) into main (13b7e48) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           19        19           
  Branches         5         5           
=========================================
  Hits            19        19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b7e48...8dcbd8a. Read the comment docs.

@konveyor-preview-bot
Copy link

🚀 Deployed Storybook Preview: http://konveyor-lib-ui-pr-70-preview.surge.sh

Copy link

@seanforyou23 seanforyou23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I don't see anything up on http://konveyor-lib-ui.surge.sh/ just yet, do you want to run it manually at first so we can preview?

.github/workflows/test-and-release.yaml Show resolved Hide resolved
@mturley mturley merged commit 91d4089 into migtools:main Jul 1, 2021
@mturley mturley deleted the switch-to-surge branch July 1, 2021 19:17
@konveyor-release-bot
Copy link

🎉 This PR is included in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mturley added a commit that referenced this pull request Aug 31, 2021
…s to Surge to avoid DNS issues (#70)"

This reverts commit 91d4089.
mturley added a commit that referenced this pull request Sep 1, 2021
…s to Surge to avoid DNS issues (#70)" (#77)

This reverts commit 91d4089.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants