Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(statusicon): add Paused status type to StatusIcon #53

Merged
1 commit merged into from
Mar 19, 2021

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Mar 19, 2021

Needed for kubev2v/forklift-ui#440

Screen Shot 2021-03-19 at 11 16 09 AM

For now, hard-codes the default color for icons to #151515 which is the PatternFly --pf-global--Color--100. I didn't use the actual variable because for some reason it was resolving to #000, which appears to be fixed in a newer PF version. Should be fixed by a future version update (#52).

@mturley mturley requested a review from a team March 19, 2021 15:18
@konveyor-preview-bot
Copy link

🚀 Deployed Storybook Preview: http://konveyor-lib-ui-pr-53-preview.surge.sh

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #53 (16498a4) into main (a3cae11) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           19        19           
  Branches         5         5           
=========================================
  Hits            19        19           
Impacted Files Coverage Δ
src/components/StatusIcon/StatusIcon.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3cae11...16498a4. Read the comment docs.

@mturley
Copy link
Collaborator Author

mturley commented Mar 19, 2021

@gildub @fdupont-redhat would you guys mind merging this one? Needed for kubev2v/forklift-ui#440

@ghost ghost merged commit c030c2b into migtools:main Mar 19, 2021
@konveyor-release-bot
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mturley mturley deleted the paused-status branch March 19, 2021 16:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants