fix: don't throw errors in http-event-normalizer #1132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getConfiguration command
…-fetching-feature-flag-configuration
…-fetching-feature-flag-configuration
…ws-error-when-fetching-feature-flag-configuration fix(appconfig): middyjs#1009 rewrite to not use deprecated appconfig getConfiguration command
# Conflicts: # lerna.json # package-lock.json # package.json # packages/appconfig/package.json # packages/cloudwatch-metrics/package-lock.json # packages/cloudwatch-metrics/package.json # packages/core/index.js # packages/core/package-lock.json # packages/core/package.json # packages/do-not-wait-for-empty-event-loop/package-lock.json # packages/do-not-wait-for-empty-event-loop/package.json # packages/dynamodb/package-lock.json # packages/dynamodb/package.json # packages/error-logger/package-lock.json # packages/error-logger/package.json # packages/event-normalizer/package-lock.json # packages/event-normalizer/package.json # packages/http-content-encoding/package-lock.json # packages/http-content-encoding/package.json # packages/http-content-negotiation/package-lock.json # packages/http-content-negotiation/package.json # packages/http-cors/package-lock.json # packages/http-cors/package.json # packages/http-error-handler/package-lock.json # packages/http-error-handler/package.json # packages/http-event-normalizer/package-lock.json # packages/http-event-normalizer/package.json # packages/http-header-normalizer/package-lock.json # packages/http-header-normalizer/package.json # packages/http-json-body-parser/package-lock.json # packages/http-json-body-parser/package.json # packages/http-multipart-body-parser/package-lock.json # packages/http-multipart-body-parser/package.json # packages/http-partial-response/package-lock.json # packages/http-partial-response/package.json # packages/http-response-serializer/package-lock.json # packages/http-response-serializer/package.json # packages/http-router/package-lock.json # packages/http-router/package.json # packages/http-security-headers/package-lock.json # packages/http-security-headers/package.json # packages/http-urlencode-body-parser/package-lock.json # packages/http-urlencode-body-parser/package.json # packages/http-urlencode-path-parser/package-lock.json # packages/http-urlencode-path-parser/package.json # packages/input-output-logger/package-lock.json # packages/input-output-logger/package.json # packages/rds-signer/package-lock.json # packages/rds-signer/package.json # packages/s3-object-response/package-lock.json # packages/s3-object-response/package.json # packages/s3/package-lock.json # packages/s3/package.json # packages/secrets-manager/package-lock.json # packages/secrets-manager/package.json # packages/service-discovery/package-lock.json # packages/service-discovery/package.json # packages/sqs-partial-batch-failure/package-lock.json # packages/sqs-partial-batch-failure/package.json # packages/ssm/package-lock.json # packages/ssm/package.json # packages/sts/package-lock.json # packages/sts/package.json # packages/util/package-lock.json # packages/util/package.json # packages/validator/package-lock.json # packages/validator/package.json # packages/warmup/package-lock.json # packages/warmup/package.json # packages/ws-json-body-parser/package-lock.json # packages/ws-json-body-parser/package.json # packages/ws-response/package-lock.json # packages/ws-response/package.json # packages/ws-router/package-lock.json # packages/ws-router/package.json
Feat: improve TS docs, mention Middeware-first, Handler-last pattern
…urus3 Update website to docusaurus3
# Conflicts: # package.json # website/src/components/HomepageSponsors.js # website/static/img/logo/amazon-web-services.svg
…ser/resolve-type-issues fix(middlewares/http-json-body-parser): narrow body type to string
|
Just had a thought, I could amend the middleware to be configurable, as to whether it throws an error or not. That would maintain compatibility.. |
|
Thanks for the PR and good point. It should be up to the validator to throw that error. We're just about to release v5, so your timing is perfect. If you can update it be against the |
willfarrell
requested changes
Nov 14, 2023
|
Thanks for the prompt response. I've rebased it off |
|
Will re-do with a cleaner PR git log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
A PR to propose changing the behaviour of the http-event-normalizer (more as a discussion point that formal PR)
Currently, the http-event-normalizer middleware will throw an error if the HTTP version cannot be established. For example if HTTP Method is missing from the event.
Impact:
It is a breaking change as the behaviour of the middleware will be different
Does this close any currently open issues?
No
Any relevant logs, error output, etc?
N/A
Environment:
Any other comments?
Todo List: