fix: perf

middyjs · Dec 10, 2023 · fa6c1ef · fa6c1ef
1 parent c52b834
commit fa6c1ef
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/packages/http-content-negotiation/__benchmarks__/index.js b/packages/http-content-negotiation/__benchmarks__/index.js
@@ -23,12 +23,12 @@ const warmHandler = setupHandler()
 
 await bench
   .add(
-    'Parse Headers',
+    'Parse headers',
     async (
       event = {
         headers: {
           'Accept-Charset': 'utf-8, iso-8859-5, unicode-1-1;q=0.8',
-          'Accept-Encoding': '*/*',
+          'Accept-Encoding': 'gzip, deflate, br',
           'Accept-Language': 'da, en-gb;q=0.8, en;q=0.7',
           Accept: 'text/plain; q=0.5, text/html, text/x-dvi; q=0.8, text/x-c'
         }

diff --git a/packages/http-content-negotiation/index.js b/packages/http-content-negotiation/index.js
@@ -44,7 +44,6 @@ const httpContentNegotiationMiddleware = (opts = {}) => {
         context
       )
     }
-
     if (options.parseEncodings) {
       parseHeader(
         'Accept-Encoding',
@@ -104,16 +103,17 @@ const parseHeader = (
   context[resultsName] = parseFn[type](headerValue, availableValues)
   context[resultName] = context[resultsName][0]
 
-  if (defaultToFirstValue && context[resultName] === undefined) {
-    context[resultName] = availableValues[0]
-  }
-  if (failOnMismatch && context[resultName] === undefined) {
-    // NotAcceptable
-    throw createError(
-      406,
-      `Unsupported ${type}. Acceptable values: ${availableValues.join(', ')}`,
-      { cause: { package: '@middy/http-content-negotiation' } }
-    )
+  if (context[resultName] === undefined) {
+    if (defaultToFirstValue) {
+      context[resultName] = availableValues[0]
+    } else if (failOnMismatch) {
+      // NotAcceptable
+      throw createError(
+        406,
+        `Unsupported ${type}. Acceptable values: ${availableValues.join(', ')}`,
+        { cause: { package: '@middy/http-content-negotiation' } }
+      )
+    }
   }
 }