fix: correct chat history date filtering logic #351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix incorrect date filtering logic in chat history. The previous implementation had a logical error where date comparisons were made against the chat's own date instead of the current date, causing incorrect grouping of chats in time periods.
Changes made
now
,oneWeekAgo
,oneMonthAgo
) outside the loop for better performance1d
: Today's chats only7d
: Chats from last 7 days (excluding today)30d
: Chats from 8-30 days agoelse if
statements to ensure chats appear in only one categoryProblem solved
Previously, the date comparison logic was comparing chat dates against themselves plus an offset, which would always return true. This fix ensures chats are properly categorized based on their actual age relative to the current date.
How to test