Skip to content

Commit

Permalink
Bugfixes
Browse files Browse the repository at this point in the history 
- Fixed reddit links not being handled internally
- Removed redundant url check.
- Fixed keyboard issue
  • Loading branch information
@micwallace
micwallace committed Aug 2, 2016
1 parent 0f98434 commit f0e1487
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 21 deletions.
Binary file modified reddinator/reddinator-release.apk
View file
Binary file not shown.
49 changes: 28 additions & 21 deletions reddinator/src/main/res/layout/activity_comments_context_dialog.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,51 +34,58 @@
android:id="@+id/info_panel"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:padding="6dp">
android:padding="6dp"
android:paddingTop="0dp">
<LinearLayout
android:id="@+id/title_box"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="vertical">

<IconTextView
android:id="@+id/info_txt"
style="@android:style/TextAppearance.Small"
android:layout_width="match_parent"
<TextView
android:id="@+id/source_txt"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginBottom="-24dp"
android:padding="0dp"
android:includeFontPadding="false"
android:clickable="true"
android:linksClickable="true"/>
android:text="@string/reddit_domain"
android:textColor="#336699"
android:singleLine="true"
android:ellipsize="marquee"
android:paddingBottom="4dp"/>

</LinearLayout>

<TextView
android:id="@+id/post_title"
style="@android:style/TextAppearance.Medium"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_centerVertical="true"
android:layout_alignParentLeft="true"
android:layout_alignParentStart="true"
android:layout_below="@id/title_box"
android:layout_marginBottom="2dp"/>

<TextView
android:id="@+id/source_txt"
android:layout_width="wrap_content"
<IconTextView
android:id="@+id/info_txt"
style="@android:style/TextAppearance.Small"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_centerVertical="true"
android:layout_alignParentLeft="true"
android:layout_alignParentStart="true"
android:layout_below="@id/title_box"
android:text="@string/reddit_domain"
android:textColor="#336699"
android:singleLine="true"
android:ellipsize="marquee"/>
android:layout_below="@id/post_title"
android:layout_marginBottom="-24dp"
android:padding="0dp"
android:includeFontPadding="false"
android:clickable="true"
android:linksClickable="true"/>

<IconTextView
android:id="@+id/votes_icon"
android:contentDescription="@string/icon"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_below="@id/source_txt"
android:layout_below="@id/info_txt"
android:layout_alignParentLeft="true"
android:layout_alignParentStart="true"
android:text="@string/fa_star"
Expand All @@ -91,7 +98,7 @@

<TextView
android:id="@+id/votes_txt"
android:layout_below="@id/source_txt"
android:layout_below="@id/info_txt"
android:layout_toRightOf="@+id/votes_icon"
android:layout_toEndOf="@+id/votes_icon"
android:layout_width="match_parent"
Expand Down Expand Up @@ -135,7 +142,7 @@
android:contentDescription="@string/icon"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_below="@id/source_txt"
android:layout_below="@id/info_txt"
android:layout_alignParentRight="true"
android:layout_alignParentEnd="true"
android:text="@string/fa_file_text"
Expand Down

0 comments on commit f0e1487

Please sign in to comment.