Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: Google.Chrome.Canary version 97.0.4670.2 #30443

Merged
1 commit merged into from
Oct 15, 2021
Merged

New version: Google.Chrome.Canary version 97.0.4670.2 #30443

1 commit merged into from
Oct 15, 2021

Conversation

vedantmgoyal9
Copy link
Contributor

@vedantmgoyal9 vedantmgoyal9 commented Oct 15, 2021 •
edited by ghost
Loading

Auto-updated by vedantmgoyal2009/winget-pkgs-automation

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jedieaston
jedieaston suggested changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@jedieaston jedieaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installer hash is the same every day since that version of the Chrome installer just downloads the latest version.

Can you modify your script so that you just change the folder name and PackageVersion instead of making new manifests every day (and leaving the old ones which don't work)? Then we don't have to do it in separate PRs.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Oct 15, 2021
@vedantmgoyal9
Copy link
Contributor Author

vedantmgoyal9 commented Oct 15, 2021 •
edited
Loading

Can you modify your script so that you just change the folder name and PackageVersion instead of making new manifests every day (and leaving the old ones which don't work)? Then we don't have to do it in separate PRs.

I've been previously thinking about it but Trenly#37 and Trenly#57 are already in the queue for the next version of YamlCreate so if we can wait for a few days, we can get the feature in YamlCreate.ps1 itself.

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 15, 2021
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed Possible-Duplicate labels Oct 15, 2021
@wingetbot
Copy link
Collaborator

Possible duplicate package entry.

Similar installer SHA256 hash found in manifest:

  • InstallerSha256: b0e20ff87348ced21c1d78a9f2ed78c0becb4c3ee8a4cd5ce55ae9d07d092e7d
    • manifests\g\Google\Chrome\Canary\97.0.4668.0
    • manifests\g\Google\Chrome\Canary\97.0.4669.0
    • manifests\g\Google\Chrome\Canary\97.0.4670.0
  • InstallerSha256: e734af510b7a79d6aa39c99e7c59bb8df90b5ae3f59969adc8b20fc1d662d69b
    • manifests\g\Google\Chrome\Canary\97.0.4668.0
    • manifests\g\Google\Chrome\Canary\97.0.4669.0
    • manifests\g\Google\Chrome\Canary\97.0.4670.0

@ghost
Copy link

ghost commented Oct 15, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Oct 15, 2021
@ghost
Copy link

ghost commented Oct 15, 2021

Hello @vedantmgoyal2009,
Validation has completed.

@ghost ghost merged commit f3b77d8 into microsoft:master Oct 15, 2021
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@OfficialEsco OfficialEsco deleted the Google.Chrome.Canary-97.0.4670.2-D31B488 branch February 8, 2022 11:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedieaston jedieaston jedieaston requested changes

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team. Possible-Duplicate Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vedantmgoyal9 @wingetbot @ItzLevvie @jedieaston