Add Entra Id authentication support for installer download #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
ryfu-msft
previously approved these changes
Dec 23, 2024
| </data> | ||
| <data name="InstallerDownloadAuthenticationNotSupported" xml:space="preserve"> | ||
| <value>Failed to download installer. This winget version does not support the installer download authentication method. Try upgrade to latest winget version.</value> |
There was a problem hiding this comment.
Suggested change
| <value>Failed to download installer. This winget version does not support the installer download authentication method. Try upgrade to latest winget version.</value> | |
| <value>Failed to download installer. This winget version does not support the installer download authentication method. Try upgrading to latest winget version.</value> | |
| bool MicrosoftEntraIdAuthenticationInfo::operator<(const MicrosoftEntraIdAuthenticationInfo& other) const | ||
| { | ||
| // std::tie implements tuple comparison, wherein it checks the first item in the tuple, | ||
| // iff the first elements are equal, then the second element is used for comparison, and so on |
There was a problem hiding this comment.
Suggested change
| // iff the first elements are equal, then the second element is used for comparison, and so on | |
| // if the first elements are equal, then the second element is used for comparison, and so on | |
| bool AuthenticationInfo::operator<(const AuthenticationInfo& other) const | ||
| { | ||
| // std::tie implements tuple comparison, wherein it checks the first item in the tuple, | ||
| // iff the first elements are equal, then the second element is used for comparison, and so on |
There was a problem hiding this comment.
Suggested change
| // iff the first elements are equal, then the second element is used for comparison, and so on | |
| // if the first elements are equal, then the second element is used for comparison, and so on | |
| @@ -24,9 +26,9 @@ namespace AppInstaller::Authentication | |||
|
|
|||
| AICLI_LOG(Core, Info, << "AuthenticationArguments values. Mode: " << AuthenticationModeToString(args.Mode) << ", Account: " << args.AuthenticationAccount); | |||
|
|
|||
| if (info.Type == AuthenticationType::MicrosoftEntraId) | |||
| if (info.Type == AuthenticationType::MicrosoftEntraId || info.Type == AuthenticationType::MicrosoftEntraIdForAzureBlobStorage) | |||
There was a problem hiding this comment.
nit: Should we create a semantic function for this similar to what you did for WebAccountAuthenticator?
|
Hello |
|
How are you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow