Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing setting in schema #5070

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Dec 15, 2024


This PR relates to issue #2899 and PR #4541

Microsoft Reviewers: Open in CodeFlow

@Gijsreyn Gijsreyn requested a review from a team as a code owner December 15, 2024 13:28
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback Issue needs attention from issue or PR author label Dec 15, 2024
@Gijsreyn
Copy link
Contributor Author

Also updated the code quotes in the settings.md.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention Issue needs attention from Microsoft and removed Needs-Author-Feedback Issue needs attention from issue or PR author labels Dec 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback Issue needs attention from issue or PR author label Dec 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Dec 15, 2024
@Gijsreyn Gijsreyn requested a review from Trenly December 15, 2024 16:21
@denelon
Copy link
Contributor

denelon commented Jan 6, 2025

I think I'd want an engineer to confirm the "tar" behavior works outside of the system context. I think tar support was added for system context since there is no shell API to call in that case.

schemas/JSON/settings/settings.schema.0.2.json Outdated Show resolved Hide resolved
doc/Settings.md Show resolved Hide resolved
@Gijsreyn Gijsreyn requested a review from yao-msft January 8, 2025 01:58
@yao-msft yao-msft merged commit 610efd6 into microsoft:master Jan 15, 2025
3 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention Issue needs attention from Microsoft label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants