Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The initial yaml schema manifest for version 1.7.0 #3876

Merged
merged 9 commits into from
Nov 13, 2023
Merged

The initial yaml schema manifest for version 1.7.0 #3876

merged 9 commits into from
Nov 13, 2023

Conversation

Madhusudhan-MSFT
Copy link
Contributor

@Madhusudhan-MSFT Madhusudhan-MSFT commented Nov 10, 2023 •
edited
Loading

This PR introduces the

  1. initial set of v1.7.0 manifest schema, based on v1.6.0, and
  2. includes necessary test manifests and validation tests for V1.7.0.

[How Validated:]

  1. The changes have been validated by successfully compiling the winget-cli solution folder and
  2. Running AppInstallerCLITests with the [ManifestValidation] filter, confirming all tests pass.

[Test Results:]

Filters: [ManifestValidation]
===============================================================================
All tests passed (3988 assertions in 30 test cases)
Microsoft Reviewers: Open in CodeFlow

@Madhusudhan-MSFT Madhusudhan-MSFT requested a review from a team as a code owner November 10, 2023 23:31
@denelon
Copy link
Contributor

denelon commented Nov 10, 2023

Related to:

yao-msft
yao-msft previously approved these changes Nov 13, 2023
View reviewed changes
ryfu-msft
ryfu-msft requested changes Nov 13, 2023
View reviewed changes
src/AppInstallerCLITests/AppInstallerCLITests.vcxproj.filters Outdated Show resolved Hide resolved
src/AppInstallerCLITests/AppInstallerCLITests.vcxproj Outdated Show resolved Hide resolved
src/AppInstallerCLITests/AppInstallerCLITests.vcxproj.filters Outdated
Comment on lines 924 to 938
<CopyFileToFolders Include="TestData\MultiFileManifestV1_7\ManifestV1_7-MultiFile-DefaultLocale.yaml">
<Filter>TestData\MultiFileManifestV1_7</Filter>
</CopyFileToFolders>
<CopyFileToFolders Include="TestData\MultiFileManifestV1_7\ManifestV1_7-MultiFile-Installer.yaml">
<Filter>TestData\MultiFileManifestV1_7</Filter>
</CopyFileToFolders>
<CopyFileToFolders Include="TestData\MultiFileManifestV1_7\ManifestV1_7-MultiFile-Locale.yaml">
<Filter>TestData\MultiFileManifestV1_7</Filter>
</CopyFileToFolders>
<CopyFileToFolders Include="TestData\MultiFileManifestV1_7\ManifestV1_7-MultiFile-Version.yaml">
<Filter>TestData\MultiFileManifestV1_7</Filter>
</CopyFileToFolders>
<CopyFileToFolders Include="TestData\ManifestV1_7-Singleton.yaml">
<Filter>TestData</Filter>
</CopyFileToFolders>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Also move these up so they're grouped correctly by singleton/multifile

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback Issue needs attention from issue or PR author label Nov 13, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention Issue needs attention from Microsoft and removed Needs-Author-Feedback Issue needs attention from issue or PR author labels Nov 13, 2023
@Madhusudhan-MSFT Madhusudhan-MSFT merged commit 9e9a931 into microsoft:master Nov 13, 2023
11 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention Issue needs attention from Microsoft label Nov 13, 2023
@Madhusudhan-MSFT Madhusudhan-MSFT deleted the user/masudars/manifestschema-1.7 branch November 13, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryfu-msft ryfu-msft ryfu-msft approved these changes

@yao-msft yao-msft yao-msft approved these changes

@florelis florelis Awaiting requested review from florelis

Assignees

@Madhusudhan-MSFT Madhusudhan-MSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Madhusudhan-MSFT @denelon @yao-msft @ryfu-msft